doc: edit (general) collaborator guide #34712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targos
approved these changes
Aug 10, 2020
rickyes
approved these changes
Aug 10, 2020
jasnell
approved these changes
Aug 10, 2020
antsmartian
approved these changes
Aug 11, 2020
Indeed. Rebased and force-pushed to resolve conflicts. |
Leko
approved these changes
Aug 12, 2020
|
Landed in 5f65f47 |
MylesBorins
pushed a commit
that referenced
this pull request
Aug 17, 2020
Use consistent capitalization in Consensus Seeking section, replace some _should_ usage with imperative, etc. PR-URL: #34712 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ricky Zhou <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Shingo Inoue <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Aug 20, 2020
Use consistent capitalization in Consensus Seeking section, replace some _should_ usage with imperative, etc. PR-URL: #34712 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ricky Zhou <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Shingo Inoue <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Use consistent capitalization in Consensus Seeking section, replace some _should_ usage with imperative, etc. PR-URL: #34712 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ricky Zhou <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Shingo Inoue <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Use consistent capitalization in Consensus Seeking section, replace some _should_ usage with imperative, etc. PR-URL: #34712 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ricky Zhou <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Shingo Inoue <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use consistent capitalization in Consensus Seeking section, replace some
should usage with imperative, etc.
Checklist