Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: fix EADDRNOTAVAIL error in http2 #34598

Closed
wants to merge 1 commit into from
Closed

benchmark: fix EADDRNOTAVAIL error in http2 #34598

wants to merge 1 commit into from

Conversation

rickyes
Copy link
Contributor

@rickyes rickyes commented Aug 2, 2020

Fixes: #34061

It is found that there may be errors caused by too many TCP connections. This PR is only to reduce the number of connections to avoid benchmark tests crashing. On my macOS, when the value of duration is 2, there will be no errors basically.

/cc @addaleax @BridgeAR @jasnell

Checklist

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. http2 Issues or PRs related to the http2 subsystem. labels Aug 2, 2020
@rickyes rickyes mentioned this pull request Aug 3, 2020
Closed
3 tasks
@joyeecheung
Copy link
Member

Not sure whether it's a good idea to lower the default value, but you can just pass --set duration=2 to the benchmark script by the way.

mcollina
mcollina approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

I think you can also change the ulimit of your system.

mcollina
mcollina requested changes Aug 10, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought I don't think this is needed.

@rickyes
Copy link
Contributor Author

rickyes commented Aug 12, 2020

Refs: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/660/console

@mcollina But then we wouldn't be able to run the http2 benchmarks on jenkins unless we allow duration to be configured on jenkins.

@rickyes
Copy link
Contributor Author

rickyes commented Aug 12, 2020 •
edited
Loading

Or any good suggestions ?

@aduh95 aduh95 added the stalled Issues and PRs that are stalled. label Oct 16, 2020
@github-actions
Copy link
Contributor

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

@github-actions
Copy link
Contributor

Closing this because it has stalled. Feel free to reopen if this PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions.

@github-actions github-actions bot closed this Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina requested changes

Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. http2 Issues or PRs related to the http2 subsystem. stalled Issues and PRs that are stalled.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Benchmark CI run error: benchmark/_test-double-benchmarker
5 participants
@rickyes @joyeecheung @mcollina @aduh95 @nodejs-github-bot