Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add HPE_UNEXPECTED_CONTENT_LENGTH error description #34596

Conversation

nikolaykrashnikov
Copy link
Contributor

@nikolaykrashnikov nikolaykrashnikov commented Aug 1, 2020

add HPE_UNEXPECTED_CONTENT_LENGTH error description

Checklist

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 1, 2020
@nikolaykrashnikov nikolaykrashnikov force-pushed the doc/add-hucl-error-description branch 3 times, most recently from 764c266 to 7828165 Compare August 1, 2020 22:38
@nikolaykrashnikov
Copy link
Contributor Author

how can i fix the linter test?

doc/api/http.md Outdated Show resolved Hide resolved
@nikolaykrashnikov nikolaykrashnikov force-pushed the doc/add-hucl-error-description branch 4 times, most recently from 2f43719 to 0637c50 Compare August 4, 2020 08:51
@nikolaykrashnikov
Copy link
Contributor Author

@Trott @addaleax please review

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 10, 2020
doc/api/errors.md Outdated Show resolved Hide resolved
doc/api/errors.md Outdated Show resolved Hide resolved
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with or without my suggestions.

@nikolaykrashnikov nikolaykrashnikov force-pushed the doc/add-hucl-error-description branch from 0637c50 to 1781d86 Compare August 11, 2020 09:59
@nikolaykrashnikov nikolaykrashnikov force-pushed the doc/add-hucl-error-description branch from 1781d86 to 63a2cfc Compare August 11, 2020 10:00
rickyes pushed a commit that referenced this pull request Aug 11, 2020
PR-URL: #34596
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
@rickyes
Copy link
Contributor

rickyes commented Aug 11, 2020

Landed in 10ed48b

@rickyes rickyes closed this Aug 11, 2020
MylesBorins pushed a commit that referenced this pull request Aug 17, 2020
PR-URL: #34596
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
@danielleadams danielleadams mentioned this pull request Aug 20, 2020
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
PR-URL: #34596
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
PR-URL: #34596
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
PR-URL: #34596
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants