Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: use sentence-case for GOVERNANCE.md headers #34503

Merged
merged 0 commits into from
Jul 26, 2020
Merged

doc: use sentence-case for GOVERNANCE.md headers #34503

merged 0 commits into from
Jul 26, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 24, 2020

Use sentence-case in headers per style guide.

Checklist

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jul 24, 2020
@Trott
Copy link
Member Author

Trott commented Jul 25, 2020

@nodejs/documentation

richardlau
richardlau reviewed Jul 25, 2020
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The case of the headers in the TOC should also be changed to be consistent.

@Trott
Copy link
Member Author

Trott commented Jul 25, 2020

The case of the headers in the TOC should also be changed to be consistent.

Thanks! Fixed.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 25, 2020
@Trott
Copy link
Member Author

Trott commented Jul 26, 2020

Landed in 7c02446

@Trott Trott closed this Jul 26, 2020
@Trott Trott merged commit 7c02446 into nodejs:master Jul 26, 2020
@Trott Trott deleted the tri branch July 26, 2020 13:45
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
@Trott @MylesBorins
doc: use sentence-case for GOVERNANCE.md headers
17bca62 
Use sentence-case in headers per style guide.

PR-URL: #34503
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Jul 28, 2020
Merged
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
doc: use sentence-case for GOVERNANCE.md headers
00c7797 
Use sentence-case in headers per style guide.

PR-URL: #34503
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
doc: use sentence-case for GOVERNANCE.md headers
9c72591 
Use sentence-case in headers per style guide.

PR-URL: #34503
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
@mhdawson mhdawson mentioned this pull request Jan 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@richardlau richardlau richardlau approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @targos @richardlau @trivikr @nodejs-github-bot