benchmark,test: remove output from readable-async-iterator benchmark #34411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
benchmark
|
Would like to fast-track to unbreak CI. Collaborators, please 👍 here to fast-track. |
Trott
added
fast-track
richardlau
approved these changes
Jul 17, 2020
ronag
approved these changes
Jul 17, 2020
|
Did I make a mistake somewhere when landing #34035? Shouldn't I have seen this in CI? |
The last CI on the relevant PR was two weeks ago, but we only re-added benchmark tests to CI in the last day or two. You did everything the way you were supposed to. @mmarchini is working on a commit queue and if that works out, it should prevent stuff like this in the future. |
Trott
added
the
author ready
Trott
added a commit
that referenced
this pull request
Jul 17, 2020
Extra output makes test-benchmark-streams fail. Change console.log() to console.assert(). Fixes: #34409 PR-URL: #34411 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
Trott
force-pushed
the
fix-benchmark-test
branch
from
7a7aa9b to
d10c59f
Compare
|
Landed in d10c59f |
|
Adding |
cjihrig
pushed a commit
that referenced
this pull request
Jul 23, 2020
Extra output makes test-benchmark-streams fail. Change console.log() to console.assert(). Fixes: #34409 PR-URL: #34411 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extra output makes test-benchmark-streams fail. Change console.log() to
console.assert().
Fixes: #34409
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes