n-api: add version to wasm registration #34045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
jasnell
approved these changes
Jun 25, 2020
gabrielschulhof
approved these changes
Jun 26, 2020
tniessen
approved these changes
Jun 28, 2020
PR-URL: nodejs#34045 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
devsnek
force-pushed
the
napi-wasm-version-reg
branch
from
ff82cc4 to
b327d33
Compare
|
landed in b327d33 |
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
PR-URL: #34045 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
PR-URL: #34045 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jul 10, 2020
PR-URL: #34045 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jul 12, 2020
PR-URL: #34045 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jul 14, 2020
PR-URL: #34045 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the wasm entrypoint from
_napi_registertonapi_register_wasm_v##NAPI_API_VERSION.cc @nodejs/n-api
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes