Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: use npm team for npm upgrades in collaborator guide #33999

Closed
wants to merge 0 commits into from
Closed

doc: use npm team for npm upgrades in collaborator guide #33999

wants to merge 0 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 21, 2020

The collaborator guide suggests pinging individuals about npm upgrades.
Change to pinging the npm team instead.

Ping @nodejs/npm @Fishrock123 @MylesBorins

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 21, 2020
@Trott
Copy link
Member Author

Trott commented Jun 23, 2020

@nodejs/collaborators This could use some reviews. Seems like it would be pretty non-controversial.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 23, 2020
Trott added a commit that referenced this pull request Jun 23, 2020
@Trott
doc: use npm team for npm upgrades in collaborator guide
680d7a0 
The collaborator guide suggests pinging individuals about npm upgrades.
Change to pinging the npm team instead.

PR-URL: #33999
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
@Trott
Copy link
Member Author

Trott commented Jun 23, 2020

Landed in 680d7a0

@Trott Trott closed this Jun 23, 2020
@Trott Trott deleted the npm-updates branch June 23, 2020 13:42
codebytere pushed a commit that referenced this pull request Jun 27, 2020
@Trott @codebytere
doc: use npm team for npm upgrades in collaborator guide
5a4dcfc 
The collaborator guide suggests pinging individuals about npm upgrades.
Change to pinging the npm team instead.

PR-URL: #33999
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@Trott @codebytere
doc: use npm team for npm upgrades in collaborator guide
cd7812e 
The collaborator guide suggests pinging individuals about npm upgrades.
Change to pinging the npm team instead.

PR-URL: #33999
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
codebytere pushed a commit that referenced this pull request Jul 10, 2020
@Trott @codebytere
doc: use npm team for npm upgrades in collaborator guide
bce5e61 
The collaborator guide suggests pinging individuals about npm upgrades.
Change to pinging the npm team instead.

PR-URL: #33999
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
codebytere pushed a commit that referenced this pull request Jul 12, 2020
@Trott @codebytere
doc: use npm team for npm upgrades in collaborator guide
30b5e76 
The collaborator guide suggests pinging individuals about npm upgrades.
Change to pinging the npm team instead.

PR-URL: #33999
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
@codebytere codebytere mentioned this pull request Jul 13, 2020
Merged
codebytere pushed a commit that referenced this pull request Jul 14, 2020
@Trott @codebytere
doc: use npm team for npm upgrades in collaborator guide
fb15482 
The collaborator guide suggests pinging individuals about npm upgrades.
Change to pinging the npm team instead.

PR-URL: #33999
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puzpuzpuz puzpuzpuz puzpuzpuz approved these changes

@Flarna Flarna Flarna approved these changes

@targos targos targos approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @jasnell @addaleax @targos @Flarna @puzpuzpuz @nodejs-github-bot