http2: always call callback on Http2ServerResponse#end #33911
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Jun 16, 2020
lundibundi
approved these changes
Jun 16, 2020
Co-authored-by: Denys Otrishko <[email protected]>
lpinca
approved these changes
Jun 18, 2020
addaleax
added
the
author ready
|
Landed in fdcd489 🎉 (Edit: Github won’t let me close this PR. Not sure what’s up with that, I’ll probably try again later?) |
addaleax
pushed a commit
that referenced
this pull request
Jun 19, 2020
Fixes: #28001 PR-URL: #33911 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jun 27, 2020
Fixes: #28001 PR-URL: #33911 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
Fixes: #28001 PR-URL: #33911 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jul 10, 2020
Fixes: #28001 PR-URL: #33911 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jul 12, 2020
Fixes: #28001 PR-URL: #33911 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jul 14, 2020
Fixes: #28001 PR-URL: #33911 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #28001
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes