Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: configure byte order for mips targets #33898

Closed
wants to merge 1 commit into from

Conversation

bnoordhuis
Copy link
Member

The build defaulted to the byte order of the host system but
that can be different from the endianness of the target system.

Refs: #33703 (comment)

The build defaulted to the byte order of the host system but
that can be different from the endianness of the target system.

Refs: nodejs#33703 (comment)
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Jun 16, 2020
@bnoordhuis bnoordhuis added the mips Issues and PRs related to the MIPS architecture. label Jun 16, 2020
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 19, 2020
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

jasnell pushed a commit that referenced this pull request Jun 24, 2020
The build defaulted to the byte order of the host system but
that can be different from the endianness of the target system.

Refs: #33703 (comment)

PR-URL: #33898
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@jasnell
Copy link
Member

jasnell commented Jun 24, 2020

Landed in dca8163

@jasnell jasnell closed this Jun 24, 2020
codebytere pushed a commit that referenced this pull request Jun 27, 2020
The build defaulted to the byte order of the host system but
that can be different from the endianness of the target system.

Refs: #33703 (comment)

PR-URL: #33898
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@codebytere codebytere mentioned this pull request Jun 28, 2020
codebytere pushed a commit that referenced this pull request Jun 30, 2020
The build defaulted to the byte order of the host system but
that can be different from the endianness of the target system.

Refs: #33703 (comment)

PR-URL: #33898
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
codebytere pushed a commit that referenced this pull request Jul 10, 2020
The build defaulted to the byte order of the host system but
that can be different from the endianness of the target system.

Refs: #33703 (comment)

PR-URL: #33898
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
codebytere pushed a commit that referenced this pull request Jul 12, 2020
The build defaulted to the byte order of the host system but
that can be different from the endianness of the target system.

Refs: #33703 (comment)

PR-URL: #33898
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@codebytere codebytere mentioned this pull request Jul 13, 2020
codebytere pushed a commit that referenced this pull request Jul 14, 2020
The build defaulted to the byte order of the host system but
that can be different from the endianness of the target system.

Refs: #33703 (comment)

PR-URL: #33898
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. mips Issues and PRs related to the MIPS architecture.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants