Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update the first class styling to match with other classes in fs.md #33820

Closed
wants to merge 1 commit into from
Closed

doc: update the first class styling to match with other classes in fs.md #33820

wants to merge 1 commit into from

Conversation

Shakil-Shahadat
Copy link
Contributor

First class heading is made to look like other headings.

Checklist

@Shakil-Shahadat
Update fs.md
9d27c64 
First class heading is made to look like other headings.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Jun 10, 2020
@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 10, 2020
@addaleax
Copy link
Member

Collaborators, 👍 this comment to approve fast-tracking

@HarshithaKP
Copy link
Member

This PR can be landed now!

gireeshpunathil pushed a commit that referenced this pull request Jun 22, 2020
@Shakil-Shahadat @gireeshpunathil
doc: update fs.md
73a7a24 
First class heading is made to look like other headings.

PR-URL: #33820
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@gireeshpunathil
Copy link
Member

landed in 73a7a24 , thanks for the contribution!

codebytere pushed a commit that referenced this pull request Jun 27, 2020
@Shakil-Shahadat @codebytere
doc: update fs.md
ed26e8e 
First class heading is made to look like other headings.

PR-URL: #33820
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@Shakil-Shahadat @codebytere
doc: update fs.md
b6dc51a 
First class heading is made to look like other headings.

PR-URL: #33820
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
codebytere pushed a commit that referenced this pull request Jul 10, 2020
@Shakil-Shahadat @codebytere
doc: update fs.md
d6d1230 
First class heading is made to look like other headings.

PR-URL: #33820
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
codebytere pushed a commit that referenced this pull request Jul 12, 2020
@Shakil-Shahadat @codebytere
doc: update fs.md
f29f77f 
First class heading is made to look like other headings.

PR-URL: #33820
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@codebytere codebytere mentioned this pull request Jul 13, 2020
Merged
codebytere pushed a commit that referenced this pull request Jul 14, 2020
@Shakil-Shahadat @codebytere
doc: update fs.md
f205b5f 
First class heading is made to look like other headings.

PR-URL: #33820
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rexagod rexagod rexagod approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Shakil-Shahadat @addaleax @HarshithaKP @gireeshpunathil @jasnell @lpinca @cjihrig @rexagod @nodejs-github-bot