n-api: document nextTick timing in callbacks #33804
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
mcollina
reviewed
Jun 9, 2020
mafintosh
force-pushed
the
n-api-next-tick-timing
branch
from
91b6970 to
f457dd0
Compare
mafintosh
force-pushed
the
n-api-next-tick-timing
branch
from
f457dd0 to
96d65ba
Compare
legendecas
approved these changes
Jun 9, 2020
jasnell
approved these changes
Jun 9, 2020
addaleax
approved these changes
Jun 9, 2020
mafintosh
force-pushed
the
n-api-next-tick-timing
branch
from
96d65ba to
e848bb4
Compare
|
Updated the message |
legendecas
approved these changes
Jun 11, 2020
| @@ -4755,6 +4755,9 @@ is sufficient and appropriate. Use of the `napi_make_callback` function | |||
| may be required when implementing custom async behavior that does not use | |||
| `napi_create_async_work`. | |||
|
|
|||
| Any `process.nextTick`s or Promises scheduled on the microtask queue by | |||
| JavaScript during the callback are ran before returning back to C/C++. | |||
There was a problem hiding this comment.
Suggested change
| JavaScript during the callback are ran before returning back to C/C++. | |
| JavaScript during the callback are run before returning back to C/C++. |
There was a problem hiding this comment.
Better perhaps?
Suggested change
| JavaScript during the callback are ran before returning back to C/C++. | |
| JavaScript during the callback are executed before returning back to C/C++. |
gabrielschulhof
approved these changes
Jun 15, 2020
mhdawson
approved these changes
Jun 16, 2020
mcollina
pushed a commit
that referenced
this pull request
Jun 17, 2020
PR-URL: #33804 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
|
Landed in 50fb019 |
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
PR-URL: #33804 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
PR-URL: #33804 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jul 10, 2020
PR-URL: #33804 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jul 14, 2020
PR-URL: #33804 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
This was referenced May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesDocument that nextTicks when c/c++ calls js are ran before returning to c/c++ if any are scheduled by the js callback. Just fixed a bug in Electron related to this, so thought we could help others avoid this quirk by making it more clear.