-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
querystring: improve stringify() performance #33669
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
querystring
Issues and PRs related to the built-in querystring module.
performance
Issues and PRs related to the performance of Node.js.
labels
May 31, 2020
@bricss why are you upvoting every new PR :D? |
benjamingr
approved these changes
May 31, 2020
BridgeAR
force-pushed
the
master
branch
2 times, most recently
from
May 31, 2020 12:18
8ae28ff
to
2935f72
Compare
@benjamingr I wouldn't consider this as a upvote, but as regular like 🙂 |
BridgeAR
reviewed
May 31, 2020
mscdex
force-pushed
the
querystring-stringify-perf
branch
2 times, most recently
from
June 2, 2020 14:45
d4c300d
to
0ce72f8
Compare
mscdex
force-pushed
the
querystring-stringify-perf
branch
from
June 3, 2020 02:29
0ce72f8
to
06bdb24
Compare
I've made further changes that have netted even larger improvements across the board. |
PR-URL: nodejs#33669 Reviewed-By: Benjamin Gruenbaum <[email protected]>
mscdex
force-pushed
the
querystring-stringify-perf
branch
from
June 12, 2020 22:22
06bdb24
to
7b46793
Compare
18 tasks
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
PR-URL: #33669 Reviewed-By: Benjamin Gruenbaum <[email protected]>
36 tasks
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
PR-URL: #33669 Reviewed-By: Benjamin Gruenbaum <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jul 10, 2020
PR-URL: #33669 Reviewed-By: Benjamin Gruenbaum <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jul 14, 2020
PR-URL: #33669 Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
performance
Issues and PRs related to the performance of Node.js.
querystring
Issues and PRs related to the built-in querystring module.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark results:
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes