Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: simplify format in node_file.cc #33660

Closed
wants to merge 4 commits into from
+4 −4
Closed

src: simplify format in node_file.cc #33660

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
904aa7c
src: simplify format in node_file.cc
himself65 May 30, 2020
026fefd
fixup!
himself65 May 30, 2020
3de1129
fixup!
himself65 May 31, 2020
a93aa82
fixup!
himself65 May 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/node_file.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,9 +454,9 @@ int FileHandle::ReadStart() {

// Push the read wrap back to the freelist, or let it be destroyed
// once we’re exiting the current scope.
constexpr size_t wanted_freelist_fill = 100;
constexpr size_t kWantedFreelistFill = 100;
auto& freelist = handle->binding_data_->file_handle_read_wrap_freelist;
if (freelist.size() < wanted_freelist_fill) {
if (freelist.size() < kWantedFreelistFill) {
read_wrap->Reset();
freelist.emplace_back(std::move(read_wrap));
}
Expand Down Expand Up @@ -721,7 +721,7 @@ void AfterScanDir(uv_fs_t* req) {
int r;
std::vector<Local<Value>> name_v;

for (int i = 0; ; i++) {
for (;;) {
uv_dirent_t ent;

r = uv_fs_scandir_next(req, &ent);
Expand Down Expand Up @@ -762,7 +762,7 @@ void AfterScanDirWithTypes(uv_fs_t* req) {
std::vector<Local<Value>> name_v;
std::vector<Local<Value>> type_v;

for (int i = 0; ; i++) {
while (true) {
himself65 marked this conversation as resolved.
Show resolved Hide resolved
uv_dirent_t ent;

r = uv_fs_scandir_next(req, &ent);
Expand Down