src: perform bounds checking on error source line #33645
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
BridgeAR
force-pushed
the
master
branch
2 times, most recently
from
8ae28ff to
2935f72
Compare
|
CI: https://ci.nodejs.org/job/node-test-pull-request/31739/ (:yellow_heart:) |
Trott
approved these changes
Jun 9, 2020
|
Landed in 4678e44 |
addaleax
added a commit
that referenced
this pull request
Jun 9, 2020
Fixes: #33578 PR-URL: #33645 Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Fixes: #33578 PR-URL: #33645 Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #33578
/cc @devsnek Since I can’t reproduce, I didn’t feel 100 % comfortable to add a test here. If you can put your repro into the form of a regression test, feel free to push to this branch.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes