-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: improve http-client coverage #33633
Merged
+49
−9
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
915b724
http: do not override user-provided options object
KuthorX 2b0301f
fix code style by lint-js
KuthorX 37d005a
modify error code&msg, make client cb be called
KuthorX 289444e
fix test
aduh95 9eed9e1
fix ci error, use different port
KuthorX 33e6591
listen dynamic port
KuthorX File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
'use strict'; | ||
|
||
const common = require('../common'); | ||
const assert = require('assert'); | ||
const ClientRequest = require('http').ClientRequest; | ||
|
||
{ | ||
const req = new ClientRequest(() => {}); | ||
req.on('error', common.mustCall((err) => { | ||
assert.strictEqual(err.code, 'ECONNREFUSED'); | ||
})) | ||
assert.strictEqual(req.path, '/'); | ||
assert.strictEqual(req.method, 'GET'); | ||
} |
13 changes: 13 additions & 0 deletions
13
test/parallel/test-http-client-insecure-http-parser-error.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,13 @@ | ||||||||
'use strict'; | ||||||||
|
||||||||
const common = require('../common'); | ||||||||
const assert = require('assert'); | ||||||||
const ClientRequest = require('http').ClientRequest; | ||||||||
|
||||||||
{ | ||||||||
assert.throws(() => { | ||||||||
new ClientRequest({insecureHTTPParser: 'wrongValue'}); | ||||||||
}, { | ||||||||
code: /ERR_INVALID_ARG_TYPE/ | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
}, 'http request should throw when passing not-boolean value as insecureHTTPParser'); | ||||||||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test should definitely hit the mentioned code line but it would be great to write a test that actually verifies that the callback is also called and ideally, this test case would not cause any errors, since it's a legit code path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BridgeAR Here is a rewrote version, which can make
cb
be called, but it's a little longer than previous version, so I am not sure whether it's ok, could you help me to check?