Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

events: add event-target tests #33623

Closed
wants to merge 2 commits into from
Closed

events: add event-target tests #33623

wants to merge 2 commits into from

Conversation

benjamingr
Copy link
Member

Add tests for several scenarios:

  • Add tests for event names that are prototype methods.
  • Add test for events.on with NodeEventTarget
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@benjamingr benjamingr added the events Issues and PRs related to the events subsystem / EventEmitter. label May 28, 2020
@benjamingr benjamingr requested a review from jasnell May 28, 2020 18:47
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 28, 2020
@benjamingr
Copy link
Member Author

@jasnell I think you missed this one :]

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 30, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31645/

benjamingr added a commit that referenced this pull request May 31, 2020
@benjamingr
events: add event-target tests
e94efeb 
PR-URL: #33623
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@benjamingr
Copy link
Member Author

benjamingr commented May 31, 2020 •
edited by BridgeAR
Loading

landed in e94efeb 🎉

@benjamingr benjamingr closed this May 31, 2020
benjamingr added a commit that referenced this pull request May 31, 2020
@benjamingr
events: add event-target tests
df4eda2 
PR-URL: #33623
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR BridgeAR reopened this May 31, 2020
@lundibundi lundibundi mentioned this pull request May 31, 2020
Closed
2 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31744/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31909/

@jasnell
Copy link
Member

jasnell commented Jun 17, 2020

Ping @benjamingr ... tests are failing here.

This was referenced Jun 18, 2020
Open
Open
@jasnell jasnell added eventtarget Issues and PRs related to the EventTarget implementation. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jun 19, 2020
This was referenced Jun 20, 2020
Open
Open
benjamingr added a commit to benjamingr/io.js that referenced this pull request Jun 21, 2020
@benjamingr
events: add event-target tests
d2b9e56 
PR-URL: nodejs#33623
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@benjamingr
Copy link
Member Author

superceded already. Sorry forgot to close.

@benjamingr benjamingr closed this Jun 21, 2020
@github-actions github-actions bot mentioned this pull request Jun 22, 2020
Open
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
events Issues and PRs related to the events subsystem / EventEmitter. eventtarget Issues and PRs related to the EventTarget implementation. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benjamingr @nodejs-github-bot @jasnell @BridgeAR