Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update ESLint to 7.1.0 #33526

Merged
merged 1 commit into from
May 25, 2020
Merged

tools: update ESLint to 7.1.0 #33526

merged 1 commit into from
May 25, 2020

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented May 23, 2020

Update ESLint to 7.1.0

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label May 23, 2020
BridgeAR
BridgeAR approved these changes May 23, 2020
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31476/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 23, 2020 •
edited by cjihrig
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/31485/ 💛

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 23, 2020
@BridgeAR
Copy link
Member

Collaborators, please 👍 to fast track this (it's not an important PR but there is likely nothing blocking either, so it could land soon).

@cjihrig
tools: update ESLint to 7.1.0
e278e31 
Update ESLint to 7.1.0

PR-URL: nodejs#33526
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@cjihrig cjihrig merged commit e278e31 into nodejs:master May 25, 2020
@cjihrig cjihrig deleted the eslint branch May 25, 2020 13:54
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@cjihrig @codebytere
tools: update ESLint to 7.1.0
9325ed9 
Update ESLint to 7.1.0

PR-URL: #33526
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@cjihrig @codebytere
tools: update ESLint to 7.1.0
3b0a299 
Update ESLint to 7.1.0

PR-URL: #33526
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
codebytere pushed a commit that referenced this pull request Jul 8, 2020
@cjihrig @codebytere
tools: update ESLint to 7.1.0
ff4f9a9 
Update ESLint to 7.1.0

PR-URL: #33526
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@codebytere codebytere mentioned this pull request Jul 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himself65 himself65 himself65 approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@targos targos targos approved these changes

@antsmartian antsmartian antsmartian approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cjihrig @nodejs-github-bot @BridgeAR @antsmartian @targos @himself65