Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: [compat api] add writable* properties #33506

Closed
wants to merge 3 commits into from
Closed

http2: [compat api] add writable* properties #33506

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e847d9
http2: [compat api] add writable* properties
rexagod May 22, 2020
a103c6a
nit: rename test
rexagod May 22, 2020
a729aa1
Update test/parallel/test-http2-res-writable-properties.js
rexagod May 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions lib/internal/http2/compat.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,6 +519,18 @@ class Http2ServerResponse extends Stream {
return this[kStream].writableCorked;
}

get writableHighWaterMark() {
return this[kStream].writableHighWaterMark;
}

get writableFinished() {
return this[kStream].writableFinished;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this will need a special case and test for state.headRequest.

Copy link
Member

@ronag ronag May 24, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though I think headRequest is slightly broken or maybe I don't understand it. There is special handling for it in Http2ServerResponse.end() but not in Http2ServerResponse.write()? Not sure who is a good ping there. @jasnell?

Copy link
Member Author

@rexagod rexagod May 24, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: please create an issue if landing this PR without resolving this.

Issue: #33543

}

get writableLength() {
return this[kStream].writableLength;
}

set statusCode(code) {
code |= 0;
if (code >= 100 && code < 200)
Expand Down
30 changes: 30 additions & 0 deletions test/parallel/test-http2-res-writable-properties.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto) { common.skip('missing crypto'); }
const assert = require('assert');
const http2 = require('http2');

const server = http2.createServer(common.mustCall((req, res) => {
const hwm = req.socket.writableHighWaterMark;
assert.strictEqual(res.writableHighWaterMark, hwm);
assert.strictEqual(res.writableLength, 0);
res.write('');
const len = res.writableLength;
res.write('asd');
assert.strictEqual(res.writableLength, len + 3);
res.end();
res.on('finish', common.mustCall(() => {
assert.strictEqual(res.writableLength, 0);
assert.ok(res.writableFinished, 'writableFinished is not truthy');
server.close();
}));
}));

server.listen(0, common.mustCall(() => {
const client = http2.connect(`http://localhost:${server.address().port}`);
const request = client.request();
request.on('data', common.mustCall((d) => { }));
rexagod marked this conversation as resolved.
Show resolved Hide resolved
request.on('end', common.mustCall(() => {
client.close();
}));
}));