Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade to libuv 1.38.0 #33446

Closed
wants to merge 1 commit into from
Closed

deps: upgrade to libuv 1.38.0 #33446

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented May 17, 2020

Notable changes:

  • uv_library_shutdown() has been added.
  • uv_udp_init_ex() now accepts UV_UDP_RECVMMSG, although it
    is a no-op.
  • Obsolete MAX_PATH restrictions have been removed on Windows,
    and Windows is now long path aware.
  • Windows environment variables longer than 32,767 characters are
    now supported.
  • Linux cpu_times are now reported as milliseconds to match
    other platforms.
  • A memory leak resulting from uv_loop_init() failures has
    been fixed.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. libuv Issues and PRs related to the libuv dependency or the uv binding. labels May 17, 2020
jasnell
jasnell approved these changes May 17, 2020
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

bnoordhuis
bnoordhuis approved these changes May 18, 2020
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but the deletion of uv.gyp needs to be undone in order for the build to succeed. :-)

@cjihrig
deps: upgrade to libuv 1.38.0
6f4861f 
Notable changes:

- `uv_library_shutdown()` has been added.
- `uv_udp_init_ex()` now accepts `UV_UDP_RECVMMSG`, although it
  is a no-op.
- Obsolete `MAX_PATH` restrictions have been removed on Windows,
  and Windows is now long path aware.
- Windows environment variables longer than 32,767 characters are
  now supported.
- Linux `cpu_times` are now reported as milliseconds to match
  other platforms.
- A memory leak resulting from `uv_loop_init()` failures has
  been fixed.
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31403/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 19, 2020 •
edited by cjihrig
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/31408/ 💚

@cjihrig cjihrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 19, 2020
@addaleax
Copy link
Member

Landed in 227ad25 🎉

addaleax pushed a commit that referenced this pull request May 19, 2020
@cjihrig @addaleax
deps: upgrade to libuv 1.38.0
227ad25 
Notable changes:

- `uv_library_shutdown()` has been added.
- `uv_udp_init_ex()` now accepts `UV_UDP_RECVMMSG`, although it
  is a no-op.
- Obsolete `MAX_PATH` restrictions have been removed on Windows,
  and Windows is now long path aware.
- Windows environment variables longer than 32,767 characters are
  now supported.
- Linux `cpu_times` are now reported as milliseconds to match
  other platforms.
- A memory leak resulting from `uv_loop_init()` failures has
  been fixed.

PR-URL: #33446
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@addaleax addaleax closed this May 19, 2020
@cjihrig cjihrig deleted the libuv branch May 20, 2020 13:32
codebytere pushed a commit that referenced this pull request May 21, 2020
@cjihrig @codebytere
deps: upgrade to libuv 1.38.0
6d1dc42 
Notable changes:

- `uv_library_shutdown()` has been added.
- `uv_udp_init_ex()` now accepts `UV_UDP_RECVMMSG`, although it
  is a no-op.
- Obsolete `MAX_PATH` restrictions have been removed on Windows,
  and Windows is now long path aware.
- Windows environment variables longer than 32,767 characters are
  now supported.
- Linux `cpu_times` are now reported as milliseconds to match
  other platforms.
- A memory leak resulting from `uv_loop_init()` failures has
  been fixed.

PR-URL: #33446
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@bzoz bzoz mentioned this pull request May 22, 2020
Closed
codebytere pushed a commit that referenced this pull request Jun 7, 2020
@cjihrig @codebytere
deps: upgrade to libuv 1.38.0
ee598b7 
Notable changes:

- `uv_library_shutdown()` has been added.
- `uv_udp_init_ex()` now accepts `UV_UDP_RECVMMSG`, although it
  is a no-op.
- Obsolete `MAX_PATH` restrictions have been removed on Windows,
  and Windows is now long path aware.
- Windows environment variables longer than 32,767 characters are
  now supported.
- Linux `cpu_times` are now reported as milliseconds to match
  other platforms.
- A memory leak resulting from `uv_loop_init()` failures has
  been fixed.

PR-URL: #33446
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
codebytere pushed a commit to codebytere/node that referenced this pull request Jun 9, 2020
@cjihrig @codebytere
deps: upgrade to libuv 1.38.0
402aa1b 
Notable changes:

- `uv_library_shutdown()` has been added.
- `uv_udp_init_ex()` now accepts `UV_UDP_RECVMMSG`, although it
  is a no-op.
- Obsolete `MAX_PATH` restrictions have been removed on Windows,
  and Windows is now long path aware.
- Windows environment variables longer than 32,767 characters are
  now supported.
- Linux `cpu_times` are now reported as milliseconds to match
  other platforms.
- A memory leak resulting from `uv_loop_init()` failures has
  been fixed.

PR-URL: nodejs#33446
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@codebytere codebytere mentioned this pull request Jun 9, 2020
Merged
codebytere added a commit that referenced this pull request Jun 16, 2020
@codebytere
2020-06-16, Version 12.18.1 'Erbium' (LTS)
10c68cd 
Notable changes:

deps:
  * V8: cherry-pick 548f6c81d424 (Dominykas Blyžė) [#33484](#33484)
  * update to uvwasi 0.0.9 (Colin Ihrig) [#33445](#33445)
  * upgrade to libuv 1.38.0 (Colin Ihrig) [#33446](#33446)
  * upgrade npm to 6.14.5 (Ruy Adorno) [#33239](#33239)

PR-URL: #33811
codebytere added a commit that referenced this pull request Jun 16, 2020
@codebytere
2020-06-17, Version 12.18.1 'Erbium' (LTS)
6665f73 
Notable changes:

deps:
  * V8: cherry-pick 548f6c81d424 (Dominykas Blyžė) [#33484](#33484)
  * update to uvwasi 0.0.9 (Colin Ihrig) [#33445](#33445)
  * upgrade to libuv 1.38.0 (Colin Ihrig) [#33446](#33446)
  * upgrade npm to 6.14.5 (Ruy Adorno) [#33239](#33239)

PR-URL: #33811
codebytere added a commit that referenced this pull request Jun 17, 2020
@codebytere
2020-06-17, Version 12.18.1 'Erbium' (LTS)
e9145db 
Notable changes:

deps:
  * V8: cherry-pick 548f6c81d424 (Dominykas Blyžė) [#33484](#33484)
  * update to uvwasi 0.0.9 (Colin Ihrig) [#33445](#33445)
  * upgrade to libuv 1.38.0 (Colin Ihrig) [#33446](#33446)
  * upgrade npm to 6.14.5 (Ruy Adorno) [#33239](#33239)

PR-URL: #33811
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. libuv Issues and PRs related to the libuv dependency or the uv binding.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cjihrig @nodejs-github-bot @addaleax @bnoordhuis @jasnell @richardlau