Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix extension in esm example #33408

Merged
merged 1 commit into from
May 17, 2020
Merged

doc: fix extension in esm example #33408

merged 1 commit into from
May 17, 2020

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented May 14, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. labels May 14, 2020
@devsnek devsnek added the fast-track PRs that do not need to wait for 48 hours to land. label May 14, 2020
@devsnek
Copy link
Member Author

devsnek commented May 14, 2020

👍 to fast track

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31338/

@guybedford guybedford mentioned this pull request May 14, 2020
Closed
3 tasks
MylesBorins
MylesBorins approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devsnek
doc: fix extension in esm example
b46bbf2 
PR-URL: nodejs#33408
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@devsnek devsnek merged commit b46bbf2 into nodejs:master May 17, 2020
@devsnek devsnek deleted the fix-doc branch May 17, 2020 02:10
codebytere pushed a commit that referenced this pull request May 17, 2020
@devsnek @codebytere
doc: fix extension in esm example
7f9ccd6 
PR-URL: #33408
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@codebytere codebytere mentioned this pull request May 18, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 7, 2020
@devsnek @codebytere
doc: fix extension in esm example
22a989f 
PR-URL: #33408
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
codebytere pushed a commit that referenced this pull request Jun 9, 2020
@devsnek @codebytere
doc: fix extension in esm example
a9ed287 
PR-URL: #33408
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@codebytere codebytere mentioned this pull request Jun 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guybedford guybedford guybedford left review comments

@MrHeer MrHeer MrHeer approved these changes

@cjihrig cjihrig cjihrig approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@devsnek @nodejs-github-bot @MylesBorins @guybedford @cjihrig @MrHeer