stream: Duplex forward writableObjectMode #33390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
stream
lpinca
approved these changes
May 13, 2020
Duplex did not properly forward writableObjectMode. Fixes: nodejs#33388
lpinca
reviewed
May 13, 2020
addaleax
approved these changes
May 13, 2020
|
@ronag I think you accidentally pushed a spurious |
|
Landed in 2361b5c |
ronag
added a commit
that referenced
this pull request
May 18, 2020
Duplex did not properly forward writableObjectMode. Fixes: #33388 PR-URL: #33390 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
May 21, 2020
Duplex did not properly forward writableObjectMode. Fixes: #33388 PR-URL: #33390 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
|
Blocked on #33079 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplex did not properly forward writableObjectMode.
Fixes: #33388
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes