http: tidy up exposure of header validation #33371
Conversation
|
Ha. the change is completely internal - the tests even did not have to change 😀 |
|
mm. donno why the commit list is noisy... (first one on this for me as well, all my PRs so far started with editing a file online, and cloning the auto-generated repo) if I'm doing something wrong - tell me, I'll fix it. even create a new PR if need be. |
|
@osher Yes, we don’t do merge commits, and it’s unfortunate that the official Github docs don’t mention that If CI works, then I think you don’t need to update anything. If it doesn’t, you’ll need to update the branch again, but this time using |
| @@ -918,9 +918,8 @@ function(err, event) { | |||
| this.destroy(err); | |||
| }; | |||
|
|
|||
| OutgoingMessage.validateHeaderName = validateHeaderName; | |||
There was a problem hiding this comment.
I guess this makes this patch semver-major?
There was a problem hiding this comment.
@lpinca - good spot. Here's the thing:
this line landed just about a week ago, and was decided to be done better as it is featured now in a discussion that continued after the landing in a friendly spirit.
It was also undocumented - it's an implementation detail.
If that's a problem - then I can leave that line.
LMK how to proceed.
I updated the branch, just to learn how to do it. (edited: I think it also failed CI) What I basically did was
(that's the file name I got) cheers |
BridgeAR
added
the
author ready
PR-URL: #33371 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
|
Landed in e30a651 |
PR-URL: #33371 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #33371 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Internal refactoring, following:
Following: #33119 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes