-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix test-dns-idna2008 #33367
test: fix test-dns-idna2008 #33367
Conversation
Internet tests aren't run in our regular CI so here's a CI for internet tests run the same way we run them in node-daily-master: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/14228/ ✅ |
@nodejs/dns @nodejs/testing (Hide whitespace in the diff because a lot of lines were moved to accommodate 80-char wrapping: https://github.com/nodejs/node/pull/33367/files?diff=unified&w=1) |
The DNS server will sometimes return an IPv6 address (as seen in nightly CI from time to time). Use `family` option to force IPv4. PR-URL: nodejs#33367 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Landed in 23a61eb |
The DNS server will sometimes return an IPv6 address (as seen in nightly CI from time to time). Use `family` option to force IPv4. PR-URL: #33367 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
The DNS server will sometimes return an IPv6 address (as seen in nightly CI from time to time). Use `family` option to force IPv4. PR-URL: #33367 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
The DNS server will sometimes return an IPv6 address (as seen in nightly CI from time to time). Use `family` option to force IPv4. PR-URL: nodejs#33367 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
The DNS server will sometimes return an IPv6 address (as seen in nightly
CI from time to time). Use
family
option to force IPv4.Hide white-space changes in the diff to ignore all the code moved to accommodate line-wrapping at 80 chars.
This failed in node-daily-master last night. I'd like to fast-track. Please 👍 here if you are a Collaborator and agree this could/should be fast-tracked.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes