Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add #include <string> in json_utils.h #33332

Closed
wants to merge 1 commit into from
Closed

chore: add #include <string> in json_utils.h #33332

wants to merge 1 commit into from

Conversation

zcbenz
Copy link
Contributor

@zcbenz zcbenz commented May 10, 2020

When precompile headers are disabled this file would cause compilation errors due to #include <string> not included.

d:\a\1\s\node\src\json_utils.h(141): error C2679: binary '<<': no operator found which takes a right-hand operand of type 'std::string' (or there is no acceptable conversion)
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label May 10, 2020
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 10, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31268/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31351/

@targos
Copy link
Member

targos commented May 16, 2020

Landed in fda13d5

@targos targos closed this May 16, 2020
targos pushed a commit that referenced this pull request May 16, 2020
@zcbenz @targos
src: add #include <string> in json_utils.h
fda13d5 
When precompile headers are disabled this file would cause compilation
errors due to #include <string> not included.

PR-URL: #33332
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
codebytere pushed a commit that referenced this pull request May 16, 2020
@zcbenz @codebytere
src: add #include <string> in json_utils.h
5e5aa0b 
When precompile headers are disabled this file would cause compilation
errors due to #include <string> not included.

PR-URL: #33332
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@codebytere codebytere mentioned this pull request May 18, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 7, 2020
@zcbenz @codebytere
src: add #include <string> in json_utils.h
73c8638 
When precompile headers are disabled this file would cause compilation
errors due to #include <string> not included.

PR-URL: #33332
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
codebytere pushed a commit to codebytere/node that referenced this pull request Jun 9, 2020
@zcbenz @codebytere
src: add #include <string> in json_utils.h
29d24db 
When precompile headers are disabled this file would cause compilation
errors due to #include <string> not included.

PR-URL: nodejs#33332
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@codebytere codebytere mentioned this pull request Jun 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@zcbenz @nodejs-github-bot @targos @jasnell @cjihrig @richardlau @addaleax