test: fix test-net-throttle #33329
Merged
test: fix test-net-throttle #33329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Relevant CI run is: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/14181/ Pummel tests otherwise don't get run in CI, so only the linter and the above job are relevant. |
|
The test passed in CI. First time in something like two weeks! |
Trott
added
the
flaky-test
lpinca
approved these changes
May 9, 2020
|
Re-running relevant CI post-fixup commit: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/14184/ |
Trott
added
the
author ready
4 tasks
juanarbol
approved these changes
May 10, 2020
|
This is basically the only thing that has kept node-daily-master from being green many days now. Fast-track? 👍 here to approve if you're a Collaborator. |
Repeat writes until data is queued in memory, rather than assuming that it will happen by a certain point. Fixes: nodejs#33135 PR-URL: nodejs#33329 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
Trott
force-pushed
the
fix-test-net-throttle
branch
from
d348f0c to
5ded044
Compare
|
Landed in 5ded044 |
codebytere
pushed a commit
that referenced
this pull request
May 15, 2020
Repeat writes until data is queued in memory, rather than assuming that it will happen by a certain point. Fixes: #33135 PR-URL: #33329 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 7, 2020
Repeat writes until data is queued in memory, rather than assuming that it will happen by a certain point. Fixes: #33135 PR-URL: #33329 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repeat writes until data is queued in memory, rather than assuming that
it will happen by a certain point.
Fixes: #33135
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes