doc: fix typo in n-api.md #33319
Closed
doc: fix typo in n-api.md #33319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes what I think is a typo, even though the section in question does talk about a environment (env).
nodejs-github-bot
added
doc
addaleax
approved these changes
May 9, 2020
cjihrig
approved these changes
May 9, 2020
ghost
approved these changes
May 9, 2020
Trott
approved these changes
May 9, 2020
lpinca
approved these changes
May 10, 2020
legendecas
reviewed
May 11, 2020
gabrielschulhof
approved these changes
May 11, 2020
danbev
added a commit
that referenced
this pull request
May 12, 2020
This commit fixes what I think is a typo, even though the section in question does talk about a environment (env). PR-URL: #33319 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]>
|
Landed in 12b3e0c. |
codebytere
pushed a commit
that referenced
this pull request
May 15, 2020
This commit fixes what I think is a typo, even though the section in question does talk about a environment (env). PR-URL: #33319 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 7, 2020
This commit fixes what I think is a typo, even though the section in question does talk about a environment (env). PR-URL: #33319 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes what I think is a typo, even though the section in
question does talk about a environment (env).
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes