repl: add builtinModules #33295
Closed
repl: add builtinModules #33295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
May 8, 2020
4 tasks
|
@BridgeAR I assume that this is no longer blocked so I’ve removed the label. |
BridgeAR
force-pushed
the
document-repl-builtin-libs
branch
from
9fe98bb to
4b71003
Compare
This adds an alias to `_builtinLibs` that is documented and should as such also be accessed publicly. It does not contain any underscored modules. Signed-off-by: Ruben Bridgewater <[email protected]>
BridgeAR
force-pushed
the
document-repl-builtin-libs
branch
from
4b71003 to
6fa9948
Compare
BridgeAR
added
the
author ready
targos
approved these changes
May 23, 2020
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
May 23, 2020
This adds an alias to `_builtinLibs` that is documented and should as such also be accessed publicly. It does not contain any underscored modules. Signed-off-by: Ruben Bridgewater <[email protected]> PR-URL: nodejs#33295 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
|
Landed in 1acc14b |
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
This adds an alias to `_builtinLibs` that is documented and should as such also be accessed publicly. It does not contain any underscored modules. Signed-off-by: Ruben Bridgewater <[email protected]> PR-URL: #33295 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
This adds an alias to `_builtinLibs` that is documented and should as such also be accessed publicly. It does not contain any underscored modules. Signed-off-by: Ruben Bridgewater <[email protected]> PR-URL: #33295 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
This adds an alias to `_builtinLibs` that is documented and should as such also be accessed publicly. It does not contain any underscored modules. Signed-off-by: Ruben Bridgewater <[email protected]> PR-URL: #33295 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
addaleax
added
semver-minor
|
This would need a manual backport to v12.x |
|
I think backporting to v12.x depends on #33282. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an alias to
_builtinLibsthat is documented and shouldas such also be accessed publicly. It does not contain any
underscored modules.
Signed-off-by: Ruben Bridgewater [email protected]
TODO: Add a test#33282 should land first. It updatesthe list to contain all modules. That is currently not the case.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes