src: split out callback queue implementation from Environment #33272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn’t conceptually tied to anything Node.js-specific at all.
nodejs-github-bot
added
c++
jasnell
reviewed
May 6, 2020
jasnell
approved these changes
May 6, 2020
|
CI: https://ci.nodejs.org/job/node-test-pull-request/31196/ (:green_heart:) |
cjihrig
approved these changes
May 7, 2020
addaleax
added
the
author ready
addaleax
added a commit
that referenced
this pull request
May 9, 2020
This isn’t conceptually tied to anything Node.js-specific at all. PR-URL: #33272 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Landed in fea01c1 |
codebytere
pushed a commit
that referenced
this pull request
May 11, 2020
This isn’t conceptually tied to anything Node.js-specific at all. PR-URL: #33272 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 7, 2020
This isn’t conceptually tied to anything Node.js-specific at all. PR-URL: #33272 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn’t conceptually tied to anything Node.js-specific at all.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes