-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buffer: improve copy() performance #33214
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to create a slice when sourceEnd is out of bounds.
nodejs-github-bot
added
the
buffer
Issues and PRs related to the buffer subsystem.
label
May 2, 2020
addaleax
approved these changes
May 2, 2020
cjihrig
approved these changes
May 3, 2020
himself65
approved these changes
May 3, 2020
lpinca
approved these changes
May 3, 2020
BridgeAR
reviewed
May 3, 2020
addaleax
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
May 7, 2020
addaleax
pushed a commit
that referenced
this pull request
May 9, 2020
There is no need to create a slice when sourceEnd is out of bounds. PR-URL: #33214 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Landed in 339690c |
codebytere
pushed a commit
that referenced
this pull request
May 11, 2020
There is no need to create a slice when sourceEnd is out of bounds. PR-URL: #33214 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 7, 2020
There is no need to create a slice when sourceEnd is out of bounds. PR-URL: #33214 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
buffer
Issues and PRs related to the buffer subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to create a slice when
sourceEnd
is out of bounds.Results of included benchmark:
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes