module: lazy load 'getOptionValue' in initializeLoader #33212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
process
guybedford
approved these changes
May 4, 2020
|
@himself65, can you please explain why this change is made ? |
addaleax
approved these changes
May 4, 2020
addaleax has said what I wanna say |
jasnell
approved these changes
May 4, 2020
richardlau
approved these changes
May 6, 2020
If whoever lands this could add some words to the commit description paraphrasing the above (the "why this is being done") it would be very helpful for anyone browsing through commit history later on. |
addaleax
pushed a commit
that referenced
this pull request
May 7, 2020
This enables loading this module during early bootstrapping. PR-URL: #33212 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>
|
Landed in f153081 |
codebytere
pushed a commit
that referenced
this pull request
May 11, 2020
This enables loading this module during early bootstrapping. PR-URL: #33212 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
|
@himself65 this change can't currently apply to v12.x since a6b030d was landed with alterations on the v12.x branch: 02c4d27. I'm going to tag it for now with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes