-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Enhancing guides by fixing and making grammar more consistent #33152
Conversation
CC @addaleax |
@nodejs/documentation |
These changes look good to me, but I suspect it would be better to do this by changes rather than one doc at a time. Would you be open to this approach instead?:
Two advantages to this approach:
|
@Trott Sounds like a good idea to me! Is it possible to have this PR merged, then I can begin work with your suggested process? p.s. Thanks for the |
Yes, as long as you are okay with the potentially increased backporting workload for you that Rich mentioned. 👍 |
I'm okay with that, I don't think I will run into any issue. Thanks for the help! |
@ChrisAHolland what would also be useful is a list of the changes you will be making across the docs. For example changing to use pull request instead of PR. Documenting those things somewhere in a guide would be good to make sure we stay consistent after your pass. We might even be able to get the linter to enforce some of them. |
"somewhere in a guide"? Happy to report that we already have exactly such a guide! https://github.com/nodejs/node/blob/master/doc/guides/doc-style-guide.md |
In my opinion, yes, that would be ideal. |
Sounds good! |
Landed in 441e703 |
PR-URL: #33152 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #33152 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #33152 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: nodejs#33152 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
This pull request is the beginning of me overviewing the entirety of the
docs/guides/
folder.I am aiming to enhance the grammar and make notations more consistent to improve readability and professionalism.
If this pull request is well received and lands, I will continue with the rest of the guides!
Checklist