Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update c8 ignore comment #33151

Closed
wants to merge 1 commit into from
Closed

test: update c8 ignore comment #33151

wants to merge 1 commit into from

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Apr 30, 2020 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@bcoe bcoe requested a review from Trott April 30, 2020 00:01
@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Apr 30, 2020
@bcoe bcoe added the test Issues and PRs related to the tests. label Apr 30, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31104/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31109/

@bcoe
Copy link
Contributor Author

bcoe commented May 1, 2020

@nodejs/testing bother someone for a 👍

@bcoe bcoe added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 1, 2020
@Trott
Copy link
Member

Trott commented May 4, 2020

Landed in bde5f9b

@Trott Trott closed this May 4, 2020
Trott pushed a commit that referenced this pull request May 4, 2020
@bcoe @Trott
test: update c8 ignore comment
bde5f9b 
PR-URL: #33151
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
targos pushed a commit that referenced this pull request May 4, 2020
@bcoe @targos
test: update c8 ignore comment
60ebbc4 
PR-URL: #33151
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@targos targos mentioned this pull request May 4, 2020
Merged
targos pushed a commit that referenced this pull request May 7, 2020
@bcoe @targos
test: update c8 ignore comment
27c07f9 
PR-URL: #33151
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
targos pushed a commit that referenced this pull request May 7, 2020
@bcoe @targos
test: update c8 ignore comment
4bcc8af 
PR-URL: #33151
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@targos targos mentioned this pull request May 7, 2020
Merged
targos pushed a commit that referenced this pull request May 13, 2020
@bcoe @targos
test: update c8 ignore comment
6b02359 
PR-URL: #33151
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bcoe @nodejs-github-bot @Trott @BridgeAR