test: skip memory usage tests when ASAN is enabled #33129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running tests with an ASAN build leads to increased memory usage, rendering the memory usage assumptions in the test invalid. Refs: nodejs#32776 (comment)
jasnell
approved these changes
Apr 28, 2020
cjihrig
approved these changes
Apr 28, 2020
gengjiawen
approved these changes
Apr 28, 2020
benjamingr
approved these changes
Apr 28, 2020
mmarchini
approved these changes
Apr 28, 2020
richardlau
approved these changes
Apr 28, 2020
addaleax
added
the
author ready
|
CI: https://ci.nodejs.org/job/node-test-pull-request/31079/ (:yellow_heart:) |
lpinca
approved these changes
Apr 29, 2020
addaleax
added a commit
that referenced
this pull request
Apr 30, 2020
Running tests with an ASAN build leads to increased memory usage, rendering the memory usage assumptions in the test invalid. Refs: #32776 (comment) PR-URL: #33129 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Landed in d5e1795 |
targos
pushed a commit
that referenced
this pull request
May 4, 2020
Running tests with an ASAN build leads to increased memory usage, rendering the memory usage assumptions in the test invalid. Refs: #32776 (comment) PR-URL: #33129 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 7, 2020
Running tests with an ASAN build leads to increased memory usage, rendering the memory usage assumptions in the test invalid. Refs: #32776 (comment) PR-URL: #33129 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 13, 2020
Running tests with an ASAN build leads to increased memory usage, rendering the memory usage assumptions in the test invalid. Refs: #32776 (comment) PR-URL: #33129 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running tests with an ASAN build leads to increased memory usage,
rendering the memory usage assumptions in the test invalid.
Refs: #32776 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes