test: fix out-of-bound reads from invalid sizeof usage #33115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`sizeof(data)` does not return the correct result here, as it measures the size of the `data` variable, not what it points to.
nodejs-github-bot
added
addons
4 tasks
cjihrig
approved these changes
Apr 28, 2020
jasnell
approved these changes
Apr 28, 2020
addaleax
added
the
author ready
|
Landed in 8698dd9 |
addaleax
added a commit
that referenced
this pull request
Apr 30, 2020
`sizeof(data)` does not return the correct result here, as it measures the size of the `data` variable, not what it points to. PR-URL: #33115 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 4, 2020
`sizeof(data)` does not return the correct result here, as it measures the size of the `data` variable, not what it points to. PR-URL: #33115 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 7, 2020
`sizeof(data)` does not return the correct result here, as it measures the size of the `data` variable, not what it points to. PR-URL: #33115 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 13, 2020
`sizeof(data)` does not return the correct result here, as it measures the size of the `data` variable, not what it points to. PR-URL: #33115 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sizeof(data)does not return the correct result here, as it measuresthe size of the
datavariable, not what it points to.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes