src: use BaseObjectPtr in StreamReq::Dispose #33102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the AsyncWrap to be properly detached. Extracted from the [QUIC PR](nodejs#32379). Signed-off-by: James M Snell <[email protected]>
nodejs-github-bot
added
the
c++
addaleax
approved these changes
Apr 27, 2020
jasnell
added
the
author ready
jasnell
added a commit
that referenced
this pull request
May 6, 2020
Allow the AsyncWrap to be properly detached. Extracted from the [QUIC PR](#32379). Signed-off-by: James M Snell <[email protected]> PR-URL: #33102 Refs: https://github.com/nodejs/node/pull/32379/files?file-filters%5B%5D=.bat&file-filters%5B%5D=.gyp&file-filters%5B%5D=.gypi&file-filters%5B%5D=.h&file-filters%5B%5D=.md&file-filters%5B%5D=.py&file-filters%5B%5D=.sh&file-filters%5B%5D=No+extension&file-filters%5B%5D=dotfile#r409084763 Reviewed-By: Anna Henningsen <[email protected]>
|
Landed in 1dc006e |
codebytere
pushed a commit
that referenced
this pull request
May 7, 2020
Allow the AsyncWrap to be properly detached. Extracted from the [QUIC PR](#32379). Signed-off-by: James M Snell <[email protected]> PR-URL: #33102 Refs: https://github.com/nodejs/node/pull/32379/files?file-filters%5B%5D=.bat&file-filters%5B%5D=.gyp&file-filters%5B%5D=.gypi&file-filters%5B%5D=.h&file-filters%5B%5D=.md&file-filters%5B%5D=.py&file-filters%5B%5D=.sh&file-filters%5B%5D=No+extension&file-filters%5B%5D=dotfile#r409084763 Reviewed-By: Anna Henningsen <[email protected]>
Merged
|
@jasnell should this go back to |
|
@codebytere The changes conflict with #32307, but that’s just cleanup, and ignoring the conflicts should be totally okay here (i.e. |
|
Ah ok! sgtm - I'll take it :D |
codebytere
pushed a commit
that referenced
this pull request
Jun 9, 2020
Allow the AsyncWrap to be properly detached. Extracted from the [QUIC PR](#32379). Signed-off-by: James M Snell <[email protected]> PR-URL: #33102 Refs: https://github.com/nodejs/node/pull/32379/files?file-filters%5B%5D=.bat&file-filters%5B%5D=.gyp&file-filters%5B%5D=.gypi&file-filters%5B%5D=.h&file-filters%5B%5D=.md&file-filters%5B%5D=.py&file-filters%5B%5D=.sh&file-filters%5B%5D=No+extension&file-filters%5B%5D=dotfile#r409084763 Reviewed-By: Anna Henningsen <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the AsyncWrap to be properly detached.
Extracted from the QUIC PR.
Refs: https://github.com/nodejs/node/pull/32379/files?file-filters%5B%5D=.bat&file-filters%5B%5D=.gyp&file-filters%5B%5D=.gypi&file-filters%5B%5D=.h&file-filters%5B%5D=.md&file-filters%5B%5D=.py&file-filters%5B%5D=.sh&file-filters%5B%5D=No+extension&file-filters%5B%5D=dotfile#r409084763
/cc @addaleax @sam-github
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes