Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add util.types.isArrayBufferView() #33092

Closed
wants to merge 1 commit into from
Closed

doc: add util.types.isArrayBufferView() #33092

wants to merge 1 commit into from

Conversation

kevinoid
Copy link
Contributor

This function was added by #15663, but was never documented. This PR adds it to the documentation for util.

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. util Issues and PRs related to the built-in util module. labels Apr 27, 2020
@kevinoid
doc: add util.types.isArrayBufferView()
cb8f51e 
This function was added by nodejs#15663, but was never documented.
This commit documents it.
@kevinoid kevinoid force-pushed the doc-isArrayBufferView branch from aec04a8 to cb8f51e Compare April 27, 2020 13:18
juanarbol
juanarbol approved these changes Apr 27, 2020
View reviewed changes
Copy link
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

rexagod
rexagod approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member

@rexagod rexagod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 29, 2020
gireeshpunathil pushed a commit that referenced this pull request May 2, 2020
@kevinoid @gireeshpunathil
doc: add util.types.isArrayBufferView()
7c36ec3 
This function was added by #15663,
but was never documented. This commit documents it.

PR-URL: #33092
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
@gireeshpunathil
Copy link
Member

landed in 7c36ec3

@kevinoid
Copy link
Contributor Author

kevinoid commented May 2, 2020

Hurrah! Thanks everyone for taking the time to review and merge it.

targos pushed a commit that referenced this pull request May 4, 2020
@kevinoid @targos
doc: add util.types.isArrayBufferView()
d02ced8 
This function was added by #15663,
but was never documented. This commit documents it.

PR-URL: #33092
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
@targos targos mentioned this pull request May 4, 2020
Merged
targos pushed a commit that referenced this pull request May 7, 2020
@kevinoid @targos
doc: add util.types.isArrayBufferView()
09a7a4e 
This function was added by #15663,
but was never documented. This commit documents it.

PR-URL: #33092
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
@targos targos mentioned this pull request May 7, 2020
Merged
targos pushed a commit that referenced this pull request May 13, 2020
@kevinoid @targos
doc: add util.types.isArrayBufferView()
62143b5 
This function was added by #15663,
but was never documented. This commit documents it.

PR-URL: #33092
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puzpuzpuz puzpuzpuz puzpuzpuz approved these changes

@rexagod rexagod rexagod approved these changes

@juanarbol juanarbol juanarbol approved these changes

@shisama shisama shisama approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@kevinoid @gireeshpunathil @jasnell @lpinca @shisama @juanarbol @rexagod @puzpuzpuz @addaleax @nodejs-github-bot