Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: patch V8 to 8.1.307.31 #33080

Closed
wants to merge 1 commit into from
Closed

deps: patch V8 to 8.1.307.31 #33080

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Apr 26, 2020

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Apr 26, 2020
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 27, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 27, 2020 •
edited by addaleax
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/31027/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/3074/

@bricss bricss mentioned this pull request Apr 28, 2020
Merged
@addaleax
Copy link
Member

Fast-track this because including it in v14.1.0 (#33103) has been requested and it’s only a few hours anyway? I’m okay with that.

@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 28, 2020
@targos
Copy link
Member Author

targos commented Apr 28, 2020

no objections

addaleax pushed a commit that referenced this pull request Apr 28, 2020
@targos @addaleax
deps: patch V8 to 8.1.307.31
563efb7 
Refs: v8/v8@8.1.307.30...8.1.307.31

PR-URL: #33080
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@addaleax
Copy link
Member

Landed in 563efb7

@addaleax addaleax closed this Apr 28, 2020
@targos targos deleted the patchv8 branch April 28, 2020 13:59
BethGriggs pushed a commit that referenced this pull request Apr 28, 2020
@targos @BethGriggs
deps: patch V8 to 8.1.307.31
0c1b88f 
Refs: v8/v8@8.1.307.30...8.1.307.31

PR-URL: #33080
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 28, 2020
@targos @BethGriggs
deps: patch V8 to 8.1.307.31
56f50ae 
Refs: v8/v8@8.1.307.30...8.1.307.31

PR-URL: #33080
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@targos targos added dont-land-on-v10.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanarbol juanarbol juanarbol approved these changes

@devsnek devsnek devsnek approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@targos @nodejs-github-bot @addaleax @cjihrig @devsnek @juanarbol