src: fix invalid windowBits=8 gzip segfault #33045
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`{ windowBits: 8 }` is legal for deflate streams but not gzip streams.
Fix a nullptr dereference when formatting the error message.
Bug introduced in commit c34eae5 ("zlib: refactor zlib internals")
from September 2018.
It's also handled in C++ land now, per the previous commit, but intercepting it in JS land makes for prettier error messages.
nodejs-github-bot
added
c++
addaleax
approved these changes
Apr 24, 2020
Flarna
approved these changes
Apr 24, 2020
devnexen
approved these changes
Apr 24, 2020
addaleax
added
the
author ready
gengjiawen
reviewed
May 8, 2020
Co-authored-by: Jiawen Geng <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
May 9, 2020
`{ windowBits: 8 }` is legal for deflate streams but not gzip streams.
Fix a nullptr dereference when formatting the error message.
Bug introduced in commit c34eae5 ("zlib: refactor zlib internals")
from September 2018.
PR-URL: #33045
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: David Carlier <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
May 9, 2020
It's also handled in C++ land now, per the previous commit, but intercepting it in JS land makes for prettier error messages. PR-URL: #33045 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: David Carlier <[email protected]>
|
Landed in 3226731...d8a380e |
codebytere
pushed a commit
that referenced
this pull request
May 11, 2020
`{ windowBits: 8 }` is legal for deflate streams but not gzip streams.
Fix a nullptr dereference when formatting the error message.
Bug introduced in commit c34eae5 ("zlib: refactor zlib internals")
from September 2018.
PR-URL: #33045
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: David Carlier <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
May 11, 2020
It's also handled in C++ land now, per the previous commit, but intercepting it in JS land makes for prettier error messages. PR-URL: #33045 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: David Carlier <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 7, 2020
`{ windowBits: 8 }` is legal for deflate streams but not gzip streams.
Fix a nullptr dereference when formatting the error message.
Bug introduced in commit c34eae5 ("zlib: refactor zlib internals")
from September 2018.
PR-URL: #33045
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: David Carlier <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jun 7, 2020
It's also handled in C++ land now, per the previous commit, but intercepting it in JS land makes for prettier error messages. PR-URL: #33045 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: David Carlier <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{ windowBits: 8 }is legal for deflate streams but not gzip streams.Fix a nullptr dereference when formatting the error message.
Bug introduced in commit c34eae5 ("zlib: refactor zlib internals")
from September 2018.
zlib: reject windowBits=8 when mode=GZIP
It's also handled in C++ land now, per the previous commit, but
intercepting it in JS land makes for prettier error messages.