stream: removes unused params #32936
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
stream
lpinca
approved these changes
Apr 20, 2020
|
Subsystem in commit message should be "stream" not "lib". |
Removes the state param in the onFinished function since it's never used within it.
JesuHrz
force-pushed
the
jesuhrz/removes-unused-params
branch
from
d7dc43c to
22fdc41
Compare
|
thanks @lpinca for the feedback, I just made this change |
Flarna
approved these changes
Apr 20, 2020
|
Landed in 24a4e61 |
addaleax
pushed a commit
that referenced
this pull request
Apr 25, 2020
Removes the state param in the onFinished function since it's never used within it. PR-URL: #32936 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 27, 2020
Removes the state param in the onFinished function since it's never used within it. PR-URL: #32936 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 28, 2020
Removes the state param in the onFinished function since it's never used within it. PR-URL: #32936 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
May 9, 2020
Removes the state param in the onFinished function since it's never used within it. PR-URL: nodejs#32936 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
stateparam in theonFinishedfunctionsince it's never used within it.
make -j4 test(UNIX), orvcbuild test(Windows) passes