-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add juanarbol as collaborator #32906
Closed
juanarbol
wants to merge
1
commit into
nodejs:master
from
juanarbol:juanarbol/add-juanarbol-as-collaborator
Closed
doc: add juanarbol as collaborator #32906
juanarbol
wants to merge
1
commit into
nodejs:master
from
juanarbol:juanarbol/add-juanarbol-as-collaborator
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Apr 17, 2020
Trott
approved these changes
Apr 17, 2020
juanarbol
added
fast-track
PRs that do not need to wait for 48 hours to land.
notable-change
PRs with changes that should be highlighted in changelogs.
labels
Apr 17, 2020
cjihrig
approved these changes
Apr 17, 2020
Please +1 for fast track |
juanarbol
added a commit
that referenced
this pull request
Apr 17, 2020
PR-URL: #32906 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Landed in 8e55c27 |
BethGriggs
pushed a commit
that referenced
this pull request
Apr 27, 2020
PR-URL: #32906 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Apr 28, 2020
PR-URL: #32906 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
BridgeAR
added a commit
that referenced
this pull request
Apr 28, 2020
Notable Changes: * async_hooks**: * Merge `run` and `exit` methods (Andrey Pechkurov) #31950 * Prevent sync methods of async storage exiting outer context (Stephen Belanger) #31950 * vm: * Add `importModuleDynamically` option to compileFunction (Gus Caplan) #32985 New core collaborators: With this release, we welcome two new Node.js core collaborators: * Juan José Arboleda @juanarbol #32906 * Andrey Pechkurov @puzpuzpuz #32817 PR-URL: #33122
BethGriggs
added a commit
that referenced
this pull request
Apr 28, 2020
Notable changes: - deps: upgrade openssl sources to 1.1.1g (Hassaan Pasha) [#32971](#32971) - doc: add juanarbol as collaborator (Juan José Arboleda) [#32906](#32906) - http: doc deprecate abort and improve docs (Robert Nagy) [#32807](#32807) - module: do not warn when accessing `__esModule` of unfinished exports (Anna Henningsen) [#33048](#33048) - n-api: detect deadlocks in thread-safe function (Gabriel Schulhof) [#32860](#32860) - src: deprecate embedder APIs with replacements (Anna Henningsen) [#32858](#32858) - stream: - don't emit end after close (Robert Nagy) [#33076](#33076) - don't wait for close on legacy streams (Robert Nagy) [#33058](#33058) - pipeline should only destroy un-finished streams (Robert Nagy) [#32968](#32968) PR-URL: #33103
BridgeAR
added a commit
that referenced
this pull request
Apr 28, 2020
Notable Changes: * async_hooks**: * Merge `run` and `exit` methods (Andrey Pechkurov) #31950 * Prevent sync methods of async storage exiting outer context (Stephen Belanger) #31950 * vm: * Add `importModuleDynamically` option to compileFunction (Gus Caplan) #32985 New core collaborators: With this release, we welcome two new Node.js core collaborators: * Juan José Arboleda @juanarbol #32906 * Andrey Pechkurov @puzpuzpuz #32817 PR-URL: #33122
BethGriggs
added a commit
that referenced
this pull request
Apr 28, 2020
Notable changes: - deps: upgrade openssl sources to 1.1.1g (Hassaan Pasha) [#32971](#32971) - doc: add juanarbol as collaborator (Juan José Arboleda) [#32906](#32906) - http: doc deprecate abort and improve docs (Robert Nagy) [#32807](#32807) - module: do not warn when accessing `__esModule` of unfinished exports (Anna Henningsen) [#33048](#33048) - n-api: detect deadlocks in thread-safe function (Gabriel Schulhof) [#32860](#32860) - src: deprecate embedder APIs with replacements (Anna Henningsen) [#32858](#32858) - stream: - don't emit end after close (Robert Nagy) [#33076](#33076) - don't wait for close on legacy streams (Robert Nagy) [#33058](#33058) - pipeline should only destroy un-finished streams (Robert Nagy) [#32968](#32968) - vm: add importModuleDynamically option to compileFunction (Gus Caplan) [#32985](#32985) PR-URL: #33103
BethGriggs
added a commit
that referenced
this pull request
Apr 29, 2020
Notable changes: - deps: upgrade openssl sources to 1.1.1g (Hassaan Pasha) [#32971](#32971) - doc: add juanarbol as collaborator (Juan José Arboleda) [#32906](#32906) - http: doc deprecate abort and improve docs (Robert Nagy) [#32807](#32807) - module: do not warn when accessing `__esModule` of unfinished exports (Anna Henningsen) [#33048](#33048) - n-api: detect deadlocks in thread-safe function (Gabriel Schulhof) [#32860](#32860) - src: deprecate embedder APIs with replacements (Anna Henningsen) [#32858](#32858) - stream: - don't emit end after close (Robert Nagy) [#33076](#33076) - don't wait for close on legacy streams (Robert Nagy) [#33058](#33058) - pipeline should only destroy un-finished streams (Robert Nagy) [#32968](#32968) - vm: add importModuleDynamically option to compileFunction (Gus Caplan) [#32985](#32985) PR-URL: #33103
BethGriggs
added a commit
that referenced
this pull request
Apr 29, 2020
Notable changes: - deps: upgrade openssl sources to 1.1.1g (Hassaan Pasha) [#32971](#32971) - doc: add juanarbol as collaborator (Juan José Arboleda) [#32906](#32906) - http: doc deprecate abort and improve docs (Robert Nagy) [#32807](#32807) - module: do not warn when accessing `__esModule` of unfinished exports (Anna Henningsen) [#33048](#33048) - n-api: detect deadlocks in thread-safe function (Gabriel Schulhof) [#32860](#32860) - src: deprecate embedder APIs with replacements (Anna Henningsen) [#32858](#32858) - stream: - don't emit end after close (Robert Nagy) [#33076](#33076) - don't wait for close on legacy streams (Robert Nagy) [#33058](#33058) - pipeline should only destroy un-finished streams (Robert Nagy) [#32968](#32968) - vm: add importModuleDynamically option to compileFunction (Gus Caplan) [#32985](#32985) PR-URL: #33103
BridgeAR
added a commit
that referenced
this pull request
Apr 29, 2020
Notable Changes: * async_hooks**: * Merge `run` and `exit` methods (Andrey Pechkurov) #31950 * Prevent sync methods of async storage exiting outer context (Stephen Belanger) #31950 * vm: * Add `importModuleDynamically` option to compileFunction (Gus Caplan) #32985 New core collaborators: With this release, we welcome two new Node.js core collaborators: * Juan José Arboleda @juanarbol #32906 * Andrey Pechkurov @puzpuzpuz #32817 PR-URL: #33122
targos
pushed a commit
that referenced
this pull request
Apr 30, 2020
PR-URL: #32906 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
doc
Issues and PRs related to the documentations.
fast-track
PRs that do not need to wait for 48 hours to land.
notable-change
PRs with changes that should be highlighted in changelogs.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes