Revert "n-api: detect deadlocks in thread-safe function" #32880
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit aeb7084. The solution creates incorrect behaviour on Windows. Re: nodejs/node-addon-api#697 (comment) Signed-off-by: Gabriel Schulhof <[email protected]>
nodejs-github-bot
added
c++
|
Let's revert this until we come up with a better solution in #32860. |
gireeshpunathil
approved these changes
Apr 16, 2020
cjihrig
approved these changes
Apr 16, 2020
legendecas
approved these changes
Apr 16, 2020
|
aeb7084 went out in 13.13.0. Is the issue serious enough that this revert should be pulled into 14.0.0 or can it wait for the next patch release? cc FYI @BethGriggs |
addaleax
added
author ready
|
@richardlau I would pull it into v14.0.0. As a revert, this is very low-risk. |
|
@richardlau the issue is pretty serious. On Windows a secondary thread will receive a heretofore unseen non-ok status message even though it would not have caused a deadlock. This is just plain wrong. Pulling this out of v14.0.0 is definitely warranted IMO. |
|
@richardlau to be clear: I strongly believe that this PR should be a part of v14.0.0. |
That's fine, I just wanted to make sure that @BethGriggs was aware of it if that was the case. |
bnoordhuis
approved these changes
Apr 16, 2020
Flarna
approved these changes
Apr 16, 2020
gabrielschulhof
pushed a commit
that referenced
this pull request
Apr 16, 2020
This reverts commit aeb7084. The solution creates incorrect behaviour on Windows. Re: nodejs/node-addon-api#697 (comment) Signed-off-by: Gabriel Schulhof <[email protected]> PR-URL: #32880 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
|
Landed in d3d5eca. |
MylesBorins
pushed a commit
that referenced
this pull request
Apr 17, 2020
This reverts commit aeb7084. The solution creates incorrect behaviour on Windows. Re: nodejs/node-addon-api#697 (comment) Signed-off-by: Gabriel Schulhof <[email protected]> PR-URL: #32880 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Apr 20, 2020
This reverts commit aeb7084. The solution creates incorrect behaviour on Windows. Re: nodejs/node-addon-api#697 (comment) Signed-off-by: Gabriel Schulhof <[email protected]> PR-URL: nodejs#32880 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
This reverts commit aeb7084. The solution creates incorrect behaviour on Windows. Re: nodejs/node-addon-api#697 (comment) Signed-off-by: Gabriel Schulhof <[email protected]> PR-URL: #32880 Backport-PR-URL: #32948 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit aeb7084.
The solution creates incorrect behaviour on Windows.
Re: nodejs/node-addon-api#697 (comment)
Signed-off-by: @gabrielschulhof
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes