Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: elevate already elevated v8::HeapSnapshot namespace #32854

Closed
wants to merge 1 commit into from
Closed

src: elevate already elevated v8::HeapSnapshot namespace #32854

wants to merge 1 commit into from

Conversation

juanarbol
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Apr 14, 2020
addaleax
addaleax approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, Node.js commit messages are the only things that refers to this as “elevating namespaces”. I assume somebody started using it at some point and other people just followed that convention. I don’t really have a good alternative suggestion, but if somebody does, feel free to mention that. :)

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 14, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30739/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30745/

@gireeshpunathil
Copy link
Member

@addaleax - I suspect / confess that it was me who came with this wording! (unless someone want to claim this :) ) . Alternative is:

  • abstract namespace resolution: replacing a::b to using a; and then just using b
  • remove redundant namespace resolution: removing a:: from a::b where a namespace is already declared (changes such as this)

@juanarbol
Copy link
Member Author

@gireeshpunathil remove redundant namespace resolution is very elegant, I like it! Thank you sr!

juanarbol added a commit that referenced this pull request Apr 18, 2020
@juanarbol
src: remove redundant v8::HeapSnapshot namespace
392bba4 
PR-URL: #32854
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@juanarbol
Copy link
Member Author

Landed in 392bba4

@juanarbol juanarbol closed this Apr 18, 2020
BethGriggs pushed a commit that referenced this pull request Apr 27, 2020
@juanarbol @BethGriggs
src: remove redundant v8::HeapSnapshot namespace
ca7e0a2 
PR-URL: #32854
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Apr 27, 2020
Merged
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
@juanarbol @BridgeAR
src: remove redundant v8::HeapSnapshot namespace
9fd0c35 
PR-URL: #32854
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Apr 28, 2020
Merged
targos pushed a commit that referenced this pull request Apr 30, 2020
@juanarbol @targos
src: remove redundant v8::HeapSnapshot namespace
71bdcae 
PR-URL: #32854
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@targos targos mentioned this pull request May 2, 2020
Merged
@juanarbol juanarbol deleted the juanarbol/elevated-namespace branch January 19, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@juanarbol @nodejs-github-bot @gireeshpunathil @jasnell @addaleax @cjihrig @BridgeAR