Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: improve comments regarding end() errors. #32839

Closed
wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Apr 14, 2020

Cleans up comments and TODOs and tries to provide a
more detail description in regards to error behavior
of end().

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Cleans up comments and TODOs and tries to provide a
more detail description in regards to error behavior
of end().
@ronag ronag added the stream Issues and PRs related to the stream subsystem. label Apr 14, 2020
@ronag ronag requested review from mcollina, lpinca and BridgeAR April 14, 2020 06:28
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag mentioned this pull request Apr 14, 2020
4 tasks
@ronag ronag added dont-land-on-v10.x author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 14, 2020
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 14, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/30718/ (:heavy_check_mark:)

ronag added a commit that referenced this pull request Apr 16, 2020
Cleans up comments and TODOs and tries to provide a
more detail description in regards to error behavior
of end().

PR-URL: #32839
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@ronag
Copy link
Member Author

ronag commented Apr 16, 2020

Landed in 4a6a5c3

@ronag ronag closed this Apr 16, 2020
MylesBorins pushed a commit that referenced this pull request Apr 17, 2020
Cleans up comments and TODOs and tries to provide a
more detail description in regards to error behavior
of end().

PR-URL: #32839
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants