-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: expose performance interface to global #32790
lib: expose performance interface to global #32790
Conversation
@@ -125,6 +125,10 @@ if (!config.noBrowserGlobals) { | |||
// https://url.spec.whatwg.org/#urlsearchparams | |||
exposeInterface(global, 'URLSearchParams', URLSearchParams); | |||
|
|||
const { performance } = require('perf_hooks'); | |||
// https://www.w3.org/TR/performance-timeline/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// https://www.w3.org/TR/performance-timeline/ | |
// https://www.w3.org/TR/performance-timeline/ | |
// https://www.w3.org/TR/hr-time-2/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also implement https://www.w3.org/TR/user-timing/
quoting my comments in #28635 (comment)
|
+1 to what @joyeecheung said. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should also expose PerformanceObserver
I'm looking at the spec for |
That depends on the specific pieces you're seeing but the short version is: we're intentionally not fully compliant because the specs written includes a built-in memory leak that we are avoiding. |
I don't know what you are referring to, but the first thing I noted is that we support the |
I could be mistaken but |
Refs: #32790 PR-URL: #33287 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Refs: #32790 PR-URL: #33287 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Performance API seems to need more love (hopefully I could help to stabilize this) and semver major cut was few weeks ago. I better close this PR. |
Oh, sorry, I see activity related to this. |
8ae28ff
to
2935f72
Compare
Refs: #32790 PR-URL: #33287 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Closing due inactivity |
May fix: #28635
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes