Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: remove .txt files from .gitignore #32710

Merged
merged 1 commit into from
Apr 10, 2020
Merged

build: remove .txt files from .gitignore #32710

merged 1 commit into from
Apr 10, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 7, 2020

Refs: #32670 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Apr 7, 2020
@Trott Trott mentioned this pull request Apr 7, 2020
Closed
2 tasks
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 7, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
sam-github
sam-github approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@sam-github sam-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If its not generated by our configure or make targets it shouldn't be in our .gitignore, LVGTM.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 8, 2020 •
edited by Trott
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/30557/ ✅

@Trott
build: remove .txt files from .gitignore
ea4b0bc 
Refs: nodejs#32670 (comment)

PR-URL: nodejs#32710
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@Trott Trott merged commit ea4b0bc into nodejs:master Apr 10, 2020
@Trott
Copy link
Member Author

Trott commented Apr 10, 2020

Landed in ea4b0bc

@Trott Trott deleted the txt branch April 10, 2020 02:58
targos pushed a commit that referenced this pull request Apr 12, 2020
@Trott @targos
build: remove .txt files from .gitignore
809d42c 
Refs: #32670 (comment)

PR-URL: #32710
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Apr 14, 2020
@Trott @BethGriggs
build: remove .txt files from .gitignore
f4d595e 
Refs: #32670 (comment)

PR-URL: #32710
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@targos targos added backport-blocked-v12.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-blocked-v12.x labels Apr 22, 2020
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@Trott @targos
build: remove .txt files from .gitignore
605b882 
Refs: nodejs#32670 (comment)

PR-URL: nodejs#32710
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
targos pushed a commit that referenced this pull request Apr 28, 2020
@Trott @targos
build: remove .txt files from .gitignore
26fee8b 
Refs: #32670 (comment)

PR-URL: #32710
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@targos targos mentioned this pull request May 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@sam-github sam-github sam-github approved these changes

Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @nodejs-github-bot @sam-github @addaleax @lpinca @targos @richardlau