Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: consistently declare BindingData class #32677

Closed
wants to merge 1 commit into from
Closed

src: consistently declare BindingData class #32677

wants to merge 1 commit into from

Conversation

sam-github
Copy link
Contributor

Its defined as a class, so forward declare as a class, fixing type
mismatch warning.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@sam-github
src: consistently declare BindingData class
7340a41 
Its defined as a class, so forward declare as a class, fixing type
mismatch warning.
@sam-github sam-github requested a review from addaleax April 6, 2020 04:30
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. labels Apr 6, 2020
@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 6, 2020
@addaleax
Copy link
Member

addaleax commented Apr 6, 2020

👍 to fast-tracking from me

@addaleax addaleax mentioned this pull request Apr 6, 2020
Closed
2 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30497/

@sam-github
Copy link
Contributor Author

Ok by me to fast-track, needs a couple more approvals before I can do that.

sam-github added a commit that referenced this pull request Apr 6, 2020
@sam-github
src: consistently declare BindingData class
95c0885 
Its defined as a class, so forward declare as a class, fixing type
mismatch warning.

PR-URL: #32677
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@sam-github
Copy link
Contributor Author

Landed in 95c0885

@sam-github sam-github closed this Apr 6, 2020
@sam-github sam-github deleted the consistent-type branch April 6, 2020 15:44
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
@sam-github @BethGriggs
src: consistently declare BindingData class
eafd64b 
Its defined as a class, so forward declare as a class, fixing type
mismatch warning.

PR-URL: #32677
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Apr 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sam-github @addaleax @nodejs-github-bot @richardlau @targos