stream: emit 'pause' on unpipe #32476
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unpipe should use pause() instead of mutating state.flowing directly so that pausing side effects such as emitting 'pause' are properly performed. Fixes: nodejs#32470
nodejs-github-bot
added
the
stream
hassaanp
approved these changes
Mar 25, 2020
Merged
|
Should we fast track this and get it included in v13.12.0? I don't know if it should so this should not count as 1 of the 2 +1s |
MylesBorins
added
the
fast-track
|
This doesn't have green CI yet. Maybe flaky test (test.parallel/test-tls-root-certificates)? I'll do a rerun/resume once it's complete (osx always takes time). I seem to be encountering quite a lot of flakiness nowadays. |
|
|
|
@MylesBorins Does that mean I can land this on master without green CI or should I keep trying until green CI is achieved? |
|
@ronag kicked off CI again. We should try and get green CI |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 26, 2020
unpipe should use pause() instead of mutating state.flowing directly so that pausing side effects such as emitting 'pause' are properly performed. Fixes: #32470 PR-URL: #32476 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
|
We did it!!! Landed in 0d0f151 |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 26, 2020
unpipe should use pause() instead of mutating state.flowing directly so that pausing side effects such as emitting 'pause' are properly performed. Fixes: #32470 PR-URL: #32476 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unpipe should use pause() instead of mutating
state.flowing directly so that pausing side
effects such as emitting 'pause' are properly
performed.
Fixes: #32470
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes