Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: mark classes while inspecting them #32332

Closed
wants to merge 3 commits into from
Closed

util: mark classes while inspecting them #32332

wants to merge 3 commits into from

Conversation

BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Mar 17, 2020 •
edited
Loading

This outlines the basic class setup when inspecting a class.

The implementation is a bit tricky but it should cover all edge cases.

Fixes: #32270

Signed-off-by: Ruben Bridgewater [email protected]

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Mar 17, 2020
@BridgeAR BridgeAR requested a review from addaleax March 17, 2020 21:38
@BridgeAR BridgeAR force-pushed the 2020-03-17-highlight-classes-while-inspecting branch from 70f4a4e to 5fb30dc Compare March 18, 2020 22:31
devsnek
devsnek previously requested changes Mar 18, 2020
View reviewed changes
lib/internal/util/inspect.js Outdated Show resolved Hide resolved
BridgeAR and others added 2 commits May 8, 2020 10:52
@BridgeAR
util: mark classes while inspecting them
3e7470e 
This outlines the basic class setup when inspecting a class.

Signed-off-by: Ruben Bridgewater <[email protected]>
@BridgeAR
fixup: address comment
03007cb 
Signed-off-by: Ruben Bridgewater <[email protected]>
@BridgeAR BridgeAR force-pushed the 2020-03-17-highlight-classes-while-inspecting branch from 5fb30dc to 03007cb Compare May 8, 2020 15:14
@BridgeAR
fixup
ef81350 
Signed-off-by: Ruben Bridgewater <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31294/

@devsnek devsnek dismissed their stale review May 12, 2020 16:29

outdated

MEGAPUNSH
MEGAPUNSH approved these changes May 14, 2020
View reviewed changes
Copy link

@MEGAPUNSH MEGAPUNSH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2020-03-17-highlight-classes-while-inspecting

@BridgeAR
Copy link
Member Author

@nodejs/util PTAL. This is open for quite a while by now.

addaleax
addaleax approved these changes May 17, 2020
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 17, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31366/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31369/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31375/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31396/

@addaleax
Copy link
Member

Landed in 3a51588

@addaleax addaleax closed this May 20, 2020
addaleax pushed a commit that referenced this pull request May 20, 2020
@BridgeAR @addaleax
util: mark classes while inspecting them
3a51588 
This outlines the basic class setup when inspecting a class.

Signed-off-by: Ruben Bridgewater <[email protected]>

PR-URL: #32332
Fixes: #32270
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@addaleax addaleax deleted the 2020-03-17-highlight-classes-while-inspecting branch May 20, 2020 10:32
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@BridgeAR @codebytere
util: mark classes while inspecting them
2380d90 
This outlines the basic class setup when inspecting a class.

Signed-off-by: Ruben Bridgewater <[email protected]>

PR-URL: #32332
Fixes: #32270
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jul 6, 2020
@BridgeAR @codebytere
util: mark classes while inspecting them
e3533ab 
This outlines the basic class setup when inspecting a class.

Signed-off-by: Ruben Bridgewater <[email protected]>

PR-URL: #32332
Fixes: #32270
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@codebytere codebytere mentioned this pull request Jul 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himself65 himself65 himself65 left review comments

@devsnek devsnek devsnek left review comments

@mscdex mscdex mscdex left review comments

@MEGAPUNSH MEGAPUNSH MEGAPUNSH approved these changes

@antsmartian antsmartian antsmartian approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

minor request on logging classes
8 participants
@BridgeAR @nodejs-github-bot @addaleax @mscdex @antsmartian @devsnek @himself65 @MEGAPUNSH