module: port source map sorting logic from chromium #31927
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Digging in to the delta between V8's source map library, and chromium's the most significant difference that jumped out at me was that we were failing to sort generated columns. Since negative offsets are not restricted in the spec, this can lead to bugs. fixes: nodejs#31286
jridgewell
approved these changes
Feb 25, 2020
There was a problem hiding this comment.
sections can also cause misordered line numbers:
node/lib/internal/source_map/source_map.js
Line 167 in 584bdd8
I would just unconditionally sort in parseMappingPayload, and let the sorting algorithm optimize. It's probably just an O(n) for already sorted.
| if (columnOffset < 0) { | ||
| hadNegativeColumnOffset = true; | ||
| } | ||
| columnNumber += columnOffset; | ||
| if (isSeparator(stringCharIterator.peek())) { |
There was a problem hiding this comment.
How much can we clean up this code? The whole iterator string iterator wrapper thing is icky to me.
There was a problem hiding this comment.
we've diverged quite a bit form the V8 implementation at this point, introducing private fields as an example. I probably wouldn't do it in this PR, but I think you could go ahead and refactor as much as you see fit.
test/parallel/test-source-map-api.js
Outdated
| function makeMinimalMap(generatedColumns, originalColumns) { | ||
| return { | ||
| sources: ['test.js'], | ||
| // Mapping from the 0th line, 0th column of the output file to the 0th |
There was a problem hiding this comment.
Suggested change
| // Mapping from the 0th line, 0th column of the output file to the 0th | |
| // Mapping from the 0th line, ${g}th column of the output file to the 0th |
| ['U', 'F', 'F'], | ||
| ['A', 'E', 'E'] | ||
| )); | ||
| assert.strictEqual(sourceMap.findEntry(0, 6).originalColumn, 4); |
joyeecheung
approved these changes
Feb 27, 2020
bcoe
added
the
author ready
Trott
approved these changes
Feb 27, 2020
bcoe
added a commit
that referenced
this pull request
Feb 28, 2020
Digging in to the delta between V8's source map library, and chromium's the most significant difference that jumped out at me was that we were failing to sort generated columns. Since negative offsets are not restricted in the spec, this can lead to bugs. fixes: #31286 PR-URL: #31927 Fixes: #31286 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rich Trott <[email protected]>
|
Landed in fb26b13 |
codebytere
pushed a commit
that referenced
this pull request
Feb 29, 2020
Digging in to the delta between V8's source map library, and chromium's the most significant difference that jumped out at me was that we were failing to sort generated columns. Since negative offsets are not restricted in the spec, this can lead to bugs. fixes: #31286 PR-URL: #31927 Fixes: #31286 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
|
Depends on #31132 to land on v12.x |
targos
added
source maps
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
Digging in to the delta between V8's source map library, and chromium's the most significant difference that jumped out at me was that we were failing to sort generated columns. Since negative offsets are not restricted in the spec, this can lead to bugs. fixes: nodejs#31286 PR-URL: nodejs#31927 Fixes: nodejs#31286 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
Digging in to the delta between V8's source map library, and chromium's the most significant difference that jumped out at me was that we were failing to sort generated columns. Since negative offsets are not restricted in the spec, this can lead to bugs. fixes: #31286 PR-URL: #31927 Fixes: #31286 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Digging in to the delta between V8's source map library, and chromium's
the most significant difference that jumped out at me was that we were
failing to sort generated columns. Since negative offsets are not
restricted in the spec, this can lead to bugs.
fixes: #31286
Reading through the Chromium source map implementation, this was the most significant logic that jumped out at me as missing. Given the number of additional dependencies Chromium's implementation has, I think we'd do better to fix this bug, and stick with the source map class we have.
@jridgewell does this logic look correct to you, I used your tests as a starting point.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes