Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: list largepage values in --help #31537

Merged
merged 1 commit into from
Feb 1, 2020
Merged

doc: list largepage values in --help #31537

merged 1 commit into from
Feb 1, 2020

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jan 27, 2020

This commit adds the supported --use-largepages values to the --help menu.

Fixes: #31533

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 27, 2020
src/node_options.cc Outdated Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 1, 2020

This commit adds the supported --use-largepages values to
the --help menu.

PR-URL: nodejs#31537
Fixes: nodejs#31533
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@cjihrig cjihrig merged commit 2272489 into nodejs:master Feb 1, 2020
@cjihrig cjihrig deleted the doc branch February 1, 2020 05:25
codebytere pushed a commit that referenced this pull request Feb 17, 2020
This commit adds the supported --use-largepages values to
the --help menu.

PR-URL: #31537
Fixes: #31533
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Feb 17, 2020
@targos
Copy link
Member

targos commented Apr 18, 2020

Depends on large pages changes to land on v12.x

targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
This commit adds the supported --use-largepages values to
the --help menu.

PR-URL: nodejs#31537
Fixes: nodejs#31533
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 28, 2020
This commit adds the supported --use-largepages values to
the --help menu.

PR-URL: #31537
Fixes: #31533
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node --help doesn't list values for --use-largepages=...
9 participants